[release/2.8] layernorm tests: Tweak test thresholds for comparing tensors #2583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#156699) After I landed this PR: pytorch#156600, this test was failing internally on large tensors because the differences were greater than tolerances on some cuda devices. We now raise the tolerances for larger tensors. Pull Request resolved: pytorch#156699 Approved by: https://github.com/eqy, https://github.com/ngimel (cherry picked from commit 36dd598)
dnikolaev-amd
changed the title
|
Jenkins build for 6124aa037f29ec6c491b9e44e17f69a469cbea79 commit finished as FAILURE |
pruthvistony
approved these changes
Aug 27, 2025
Collaborator
pruthvistony
left a comment
pruthvistony
left a comment
There was a problem hiding this comment.
Approving for now since it is upstream cherry-pipck.
But we need to find whats the root cause of this in the native kernels.
pruthvistony
deleted the
dnikolaev/layernorm_test_tweak_thresholds_for_comparing_tensors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR: pytorch#156600, this test was failing internally on large tensors because the differences were greater than tolerances on some cuda devices.
We now raise the tolerances for larger tensors.
Pull Request resolved: pytorch#156699 Approved by: https://github.com/eqy, https://github.com/ngimel
(cherry picked from commit 36dd598)
Fixes SWDEV-547998